Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned docstrings #1558

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Cleaned docstrings #1558

merged 2 commits into from
Mar 4, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Mar 4, 2024

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Documentation

PR Summary: This pull request focuses on cleaning up docstrings across various files in the codebase. The changes are aimed at improving the clarity and consistency of documentation without altering the functionality of the code itself. The modifications include the removal of unnecessary lines and formatting adjustments within the docstrings.

Decision: Comment

📝 Type: 'Documentation' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Big diff: the diff is too large to approve with confidence.

General suggestions:

  • Ensure that the removal of documentation elements, such as formatting lines, does not affect the generation of documentation or its readability in documentation tools like Sphinx. It might be beneficial to verify the generated documentation to ensure its integrity post-changes.
  • Given the focus on documentation, it's crucial to maintain the clarity and comprehensiveness of docstrings, especially for complex functionalities like serialization and geometric transformations. Reviewing the generated documentation for readability and completeness after these changes is recommended.
  • Consider the broader impact of these documentation changes on the user's ability to understand and utilize the library effectively. Ensuring that usage examples, parameter explanations, and essential details remain intact and are easily understandable is paramount.
  • While the changes are confined to documentation, confirming that existing tests pass post-modification can help ensure that no inadvertent changes were introduced to the codebase.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.pre-commit-config.yaml Show resolved Hide resolved
@ternaus ternaus merged commit bddf9c8 into main Mar 4, 2024
17 checks passed
@ternaus ternaus deleted the add_check_for_hooks branch March 4, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant