Skip to content
This repository has been archived by the owner on Sep 4, 2018. It is now read-only.

Improving disk space usage #238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

julian-weinert
Copy link

The GIT repo gets removed after uninstall of a plugin.
Also the build director gets removed after successful build.

Also adding UUID for Xcode 6.2

@guillaumealgis
Copy link
Member

Hi @julian-weinert, sorry for the long response delay.

I think removing the plugins repos when uninstalling is a great idea, thank you!

However:

  • Adding the Xcode 6.2 UUID is probably no longer relevant 😉.
  • Regarding the removal of the build folder, I think this is a good thing too, but we plan to handle thing a bit differently as discussed in Allow installing plugins with git submodule dependencies #454. The build folder will soon™ be moved to /tmp which will achieve the same goal as your PR (saving disk space).

So if you could rewrite your PR to only include the modifications to ATZInstaller.m, that would be great! Either that or open a new PR with this change if you feel this is simpler. Thank you!

@julian-weinert
Copy link
Author

Hi @guillaume-algis!
More than a year... No worries, but I'll need to get into it again.
Having the build directory in /tmp is kind of ridiculously simple and a brilliant idea!

Let me check what I wrote here and I'll rewrite it ti the installer, no issues what so ever.
Thanks for getting back to this again!

@julian-weinert
Copy link
Author

julian-weinert commented Jun 6, 2016

And sure, adding 6.2 is definitely obsolete already :D

@julian-weinert
Copy link
Author

@guillaume-algis I now removed the build dir removal. Now there's only the package deletion left and the UUID, I think you can just ignore this.

@guillaumealgis
Copy link
Member

Unfortunately, the UUID causes a conflict with master's Info.plist.

@guillaumealgis
Copy link
Member

@julian-weinert, would you mind updating your PR to fix the conflict? I'd very much like to get this PR merged into Alcatraz!

This should just be a matter of rebase -i and dropping 12684c3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants