Skip to content
This repository has been archived by the owner on Sep 4, 2018. It is now read-only.

clean the build directory when executing xcodebuild for issue #250 #261

Merged
merged 1 commit into from
May 22, 2015

Conversation

benoitsan
Copy link
Contributor

Added clean argument to xcodebuild to clean the build products before building the plugin.

This fix resolves the issue with my plugin BBUncrustifyPlugin. I tested it and now the xib file is correctly copied.

@orta
Copy link
Contributor

orta commented May 20, 2015

ping

@orta
Copy link
Contributor

orta commented May 22, 2015

Having plugins that use nibs not reliably work is a super annoying bug ( My Xcode just crashed because I forgot that Snapshots shouldn't be installed via Alcatraz. )

@jurre
Copy link
Collaborator

jurre commented May 22, 2015

I'd say 👍 if you just make those @"clean" and @"build" literals constants to keep things consistent.

@supermarin lgtm

@supermarin
Copy link
Collaborator

@benoitsan 👍 if you just extract them to constants like PROJECT

@supermarin
Copy link
Collaborator

Actually, it'll be faster if I just do it. Thanks for the contribution and sorry for the slow response!

supermarin added a commit that referenced this pull request May 22, 2015
clean the build directory when executing xcodebuild for issue #250
@supermarin supermarin merged commit 22c6a9a into alcatraz:master May 22, 2015
@benoitsan
Copy link
Contributor Author

Thanks @supermarin, good to know it's fixed, it was a critical issue for me.

@orta
Copy link
Contributor

orta commented May 22, 2015

Just tested locally and everything installed perfect, good job all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants