-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support matplotlib 3.9.0 #377
Conversation
@orbeckst Do you mind do a quick review? I will release this version after the PR is merged as this is a critical bug fix. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 28 28
Lines 1895 1895
Branches 407 407
=======================================
Hits 1873 1873
Misses 2 2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the minimum version of matplotlib that is working with this change? Update pyproject.toml, please.
We will also need this information for the conda-forge package.
LGTM! I reinstalled the bugfix branch into a fresh environment, and |
minimum version of matplotlib is 3.7. |
…hub.com/alchemistry/alchemlyb into 28-flamel-fails-the-first-time-i-ran-it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, please squash-merge when you want.
Fix alchemistry/flamel#28