fix(core): the reconnect method was causing an infinite loop (#808)

alchemyplatform · Aug 13, 2024 · 0d09472 · 0d09472
1 parent 3d5b9c5
commit 0d09472
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/account-kit/core/src/actions/reconnect.ts b/account-kit/core/src/actions/reconnect.ts
@@ -14,11 +14,14 @@ export async function reconnect(config: AlchemyAccountsConfig) {
   const signerConfig = clientStore.getState().config;
   const accountConfigs = clientStore.getState().accountConfigs;
 
-  const signer = createSigner(signerConfig);
+  const signer = clientStore.getState().signer ?? createSigner(signerConfig);
+  if (!clientStore.getState().signer) {
+    clientStore.setState({
+      signer,
+    });
+  }
+
   const chain = getChain(config);
-  clientStore.setState({
-    signer,
-  });
 
   const unsubConnected = signer.on("connected", async () => {
     if (accountConfigs[chain.id]?.["LightAccount"]) {

diff --git a/account-kit/infra/src/schema.ts b/account-kit/infra/src/schema.ts
@@ -11,7 +11,7 @@ export const AlchemyChainSchema = z.custom<Chain>((chain) => {
   const chain_ = ChainSchema.parse(chain);
 
   return chain_.rpcUrls.alchemy != null;
-}, "chain must include an alchemy rpc url. See `createAlchemyChain` or use the `AlchemyChainMap` exported from `@aa-sdk/core`");
+}, "chain must include an alchemy rpc url. See `createAlchemyChain` or import a chain from `@account-kit/infra`.");
 
 export const AlchemyProviderConfigSchema = ConnectionConfigSchema.and(
   z.object({

diff --git a/account-kit/smart-contracts/src/light-account/clients/alchemyClient.test.ts b/account-kit/smart-contracts/src/light-account/clients/alchemyClient.test.ts
@@ -102,7 +102,7 @@ describe("Light Account Client Tests", () => {
       "[
         {
           \\"code\\": \\"custom\\",
-          \\"message\\": \\"chain must include an alchemy rpc url. See \`createAlchemyChain\` or use the \`AlchemyChainMap\` exported from \`@aa-sdk/core\`\\",
+          \\"message\\": \\"chain must include an alchemy rpc url. See \`createAlchemyChain\` or import a chain from \`@account-kit/infra\`.\\",
           \\"fatal\\": true,
           \\"path\\": [
             \\"chain\\"

diff --git a/account-kit/smart-contracts/src/light-account/clients/multiOwnerAlchemyClient.test.ts b/account-kit/smart-contracts/src/light-account/clients/multiOwnerAlchemyClient.test.ts
@@ -102,7 +102,7 @@ describe("MultiOwnerLightAccount Client Tests", () => {
       "[
         {
           \\"code\\": \\"custom\\",
-          \\"message\\": \\"chain must include an alchemy rpc url. See \`createAlchemyChain\` or use the \`AlchemyChainMap\` exported from \`@aa-sdk/core\`\\",
+          \\"message\\": \\"chain must include an alchemy rpc url. See \`createAlchemyChain\` or import a chain from \`@account-kit/infra\`.\\",
           \\"fatal\\": true,
           \\"path\\": [
             \\"chain\\"