feat: add option to constructor signer with inner params directly

alchemyplatform · Nov 14, 2023 · fc6f764 · fc6f764
1 parent f05b469
commit fc6f764
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/packages/signers/src/magic/signer.ts b/packages/signers/src/magic/signer.ts
@@ -5,7 +5,7 @@ import {
 } from "@alchemy/aa-core";
 import { Magic, type MagicUserMetadata } from "magic-sdk";
 import { createWalletClient, custom, type Hash } from "viem";
-import type { MagicAuthParams } from "./types.js";
+import type { MagicAuthParams, MagicSDKParams } from "./types.js";
 
 export class MagicSigner
   implements
@@ -14,8 +14,13 @@ export class MagicSigner
   inner: Magic;
   private signer: WalletClientSigner | undefined;
 
-  constructor({ inner }: { inner: Magic }) {
-    this.inner = inner;
+  constructor(params: MagicSDKParams | { inner: Magic }) {
+    if ("inner" in params) {
+      this.inner = params.inner;
+      return;
+    }
+
+    this.inner = new Magic(params.apiKey, params.options);
   }
 
   get signerType() {

diff --git a/packages/signers/src/magic/types.ts b/packages/signers/src/magic/types.ts
@@ -1,3 +1,16 @@
+import type {
+  MagicSDKAdditionalConfiguration,
+  MagicSDKExtensionsOption,
+} from "magic-sdk";
+
 export interface MagicAuthParams {
   authenticate: () => Promise<void>;
 }
+
+export type MagicSDKParams = {
+  apiKey: string;
+  options?: MagicSDKAdditionalConfiguration<
+    string,
+    MagicSDKExtensionsOption<string>
+  >;
+};