-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add magic signer to aa-signers #229
Merged
avasisht23
merged 27 commits into
development
from
11-08-feat_add_magic_signer_to_aa-signers
Nov 28, 2023
Merged
feat: add magic signer to aa-signers #229
avasisht23
merged 27 commits into
development
from
11-08-feat_add_magic_signer_to_aa-signers
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
November 8, 2023 21:32
7 tasks
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
avasisht23
removed request for
denniswon,
rthomare,
moldy530,
dancoombs and
mokok123
November 8, 2023 21:32
moldy530
reviewed
Nov 8, 2023
avasisht23
force-pushed
the
11-08-feat_add_aa-signers_package
branch
from
November 8, 2023 22:29
0b929a0
to
0788f39
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 8, 2023 22:30
552cc7d
to
6658903
Compare
avasisht23
force-pushed
the
11-08-feat_add_aa-signers_package
branch
from
November 8, 2023 22:40
0788f39
to
8b734fa
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 8, 2023 22:40
6658903
to
e33397d
Compare
avasisht23
force-pushed
the
11-08-feat_add_aa-signers_package
branch
from
November 8, 2023 22:40
8b734fa
to
3e7efe6
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 8, 2023 22:40
e33397d
to
f6f71ca
Compare
avasisht23
force-pushed
the
11-08-feat_add_aa-signers_package
branch
from
November 9, 2023 20:46
3e7efe6
to
f3034b9
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 9, 2023 20:46
f6f71ca
to
bd37ad8
Compare
avasisht23
force-pushed
the
11-08-feat_add_aa-signers_package
branch
from
November 12, 2023 20:08
f3034b9
to
5796631
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 12, 2023 20:08
bd37ad8
to
d206a7e
Compare
avasisht23
force-pushed
the
11-08-feat_add_aa-signers_package
branch
from
November 12, 2023 20:53
5796631
to
f42443e
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 12, 2023 20:53
d206a7e
to
5ff03ab
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 27, 2023 22:29
6647ecb
to
19d06a7
Compare
mynamebrody
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly ran through from the Magic side. Looking good!
Merge activity
|
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
avasisht23
added a commit
that referenced
this pull request
Dec 3, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, see guidleines below)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:fix
)development
and notmain
?PR-Codex overview
Detailed summary
This PR introduces the
MagicSigner
class in the@alchemy/aa-signers
package. It includes the following changes:packages/signers/src/__tests__/signer.test.ts
export { MagicSigner } from "./signer.js"
andexport type * from "./types.js"
inpackages/signers/src/index.ts
"magic-sdk": "^21.3.0"
as an optional dependency inpackages/signers/package.json
packages/signers/src/magic/types.ts
andpackages/signers/src/magic/signer.ts
getAddress
,signMessage
,signTypedData
,authenticate
, andgetAuthDetails
inpackages/signers/src/magic/signer.ts
site/packages/aa-signers/magic/getAddress.md
,site/packages/aa-signers/magic/signMessage.md
,site/packages/aa-signers/magic/getAuthDetails.md
,site/packages/aa-signers/magic/constructor.md
, andsite/packages/aa-signers/magic/signTypedData.md
site/.vitepress/config.ts
to include documentation links forMagic Signer