Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add web3auth signer to aa-signers #247

Merged
merged 21 commits into from
Nov 28, 2023

Conversation

avasisht23
Copy link
Contributor

@avasisht23 avasisht23 commented Nov 13, 2023

Pull Request Checklist

  • Did you add new tests and confirm existing tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the site folder, see guidleines below)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
  • Is the base branch you're merging into development and not main?

PR-Codex overview

This PR adds the Web3AuthSigner class to the @alchemy/aa-signers package, which allows users to authenticate and interact with Web3Auth wallets. It also includes the necessary dependencies and documentation updates.

Detailed summary

  • Adds Web3AuthSigner class to @alchemy/aa-signers package
  • Includes necessary dependencies (@web3auth/modal and @web3auth/base)
  • Updates documentation for Web3AuthSigner methods: getAddress, signMessage, signTypedData, authenticate, getAuthDetails
  • Adds example usage code snippets for each method in the documentation

The following files were skipped due to too many changes: site/packages/aa-signers/web3auth/getAuthDetails.md, site/packages/aa-signers/web3auth/introduction.md, site/packages/aa-signers/web3auth/authenticate.md, packages/signers/src/web3auth/__tests__/signer.test.ts, site/packages/aa-signers/web3auth/constructor.md, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@avasisht23
Copy link
Contributor Author

@avasisht23 avasisht23 force-pushed the 11-13-feat_add_web3auth_to_aa-signers branch from c195706 to 3063a4f Compare November 13, 2023 23:18
@avasisht23 avasisht23 changed the title test: add tests for web3auth test: add web3auth to aa-signers Nov 13, 2023
@avasisht23 avasisht23 changed the title test: add web3auth to aa-signers test: add web3auth signer to aa-signers Nov 13, 2023
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from 8f597ca to 240cf0f Compare November 14, 2023 20:50
@avasisht23 avasisht23 force-pushed the 11-13-feat_add_web3auth_to_aa-signers branch from 3063a4f to ec8cb99 Compare November 14, 2023 20:50
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from 240cf0f to 8595b38 Compare November 14, 2023 22:43
@avasisht23 avasisht23 force-pushed the 11-13-feat_add_web3auth_to_aa-signers branch from ec8cb99 to f048e70 Compare November 14, 2023 22:43
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from 8595b38 to fc6f764 Compare November 14, 2023 23:27
@avasisht23 avasisht23 force-pushed the 11-13-feat_add_web3auth_to_aa-signers branch from f048e70 to e632209 Compare November 14, 2023 23:27
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from fc6f764 to bff022a Compare November 15, 2023 19:22
@avasisht23 avasisht23 force-pushed the 11-13-feat_add_web3auth_to_aa-signers branch from e632209 to 514823f Compare November 15, 2023 19:22
@avasisht23 avasisht23 changed the title test: add web3auth signer to aa-signers feat: add web3auth signer to aa-signers Nov 15, 2023
@avasisht23 avasisht23 force-pushed the 11-08-feat_add_magic_signer_to_aa-signers branch from bff022a to 453555f Compare November 17, 2023 00:45
@avasisht23 avasisht23 force-pushed the 11-13-feat_add_web3auth_to_aa-signers branch from 514823f to c7110e2 Compare November 17, 2023 00:45
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a small bug in the docs, but LGTM otherwise

@avasisht23
Copy link
Contributor Author

avasisht23 commented Nov 28, 2023

Merge activity

  • Nov 28, 1:59 PM: @avasisht23 started a stack merge that includes this pull request via Graphite.
  • Nov 28, 2:00 PM: Graphite rebased this pull request as part of a merge.
  • Nov 28, 2:04 PM: @avasisht23 merged this pull request with Graphite.

Base automatically changed from 11-08-feat_add_magic_signer_to_aa-signers to development November 28, 2023 18:59
@avasisht23 avasisht23 force-pushed the 11-13-feat_add_web3auth_to_aa-signers branch from c9279b1 to 9326842 Compare November 28, 2023 19:00
@avasisht23 avasisht23 merged commit 4368d08 into development Nov 28, 2023
3 checks passed
@avasisht23 avasisht23 deleted the 11-13-feat_add_web3auth_to_aa-signers branch November 28, 2023 19:04
@moldy530 moldy530 mentioned this pull request Dec 1, 2023
8 tasks
moldy530 pushed a commit that referenced this pull request Dec 1, 2023
moldy530 pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants