-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add web3auth signer to aa-signers #247
Merged
avasisht23
merged 21 commits into
development
from
11-13-feat_add_web3auth_to_aa-signers
Nov 28, 2023
Merged
feat: add web3auth signer to aa-signers #247
avasisht23
merged 21 commits into
development
from
11-13-feat_add_web3auth_to_aa-signers
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
November 13, 2023 23:11
This was referenced Nov 13, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
7 tasks
avasisht23
force-pushed
the
11-13-feat_add_web3auth_to_aa-signers
branch
from
November 13, 2023 23:18
c195706
to
3063a4f
Compare
avasisht23
changed the title
test: add tests for web3auth
test: add web3auth to aa-signers
Nov 13, 2023
avasisht23
changed the title
test: add web3auth to aa-signers
test: add web3auth signer to aa-signers
Nov 13, 2023
avasisht23
commented
Nov 13, 2023
moldy530
reviewed
Nov 14, 2023
moldy530
reviewed
Nov 14, 2023
moldy530
reviewed
Nov 14, 2023
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 14, 2023 20:50
8f597ca
to
240cf0f
Compare
avasisht23
force-pushed
the
11-13-feat_add_web3auth_to_aa-signers
branch
from
November 14, 2023 20:50
3063a4f
to
ec8cb99
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 14, 2023 22:43
240cf0f
to
8595b38
Compare
avasisht23
force-pushed
the
11-13-feat_add_web3auth_to_aa-signers
branch
from
November 14, 2023 22:43
ec8cb99
to
f048e70
Compare
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 14, 2023 23:27
8595b38
to
fc6f764
Compare
avasisht23
force-pushed
the
11-13-feat_add_web3auth_to_aa-signers
branch
from
November 14, 2023 23:27
f048e70
to
e632209
Compare
denniswon
reviewed
Nov 15, 2023
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 15, 2023 19:22
fc6f764
to
bff022a
Compare
avasisht23
force-pushed
the
11-13-feat_add_web3auth_to_aa-signers
branch
from
November 15, 2023 19:22
e632209
to
514823f
Compare
avasisht23
changed the title
test: add web3auth signer to aa-signers
feat: add web3auth signer to aa-signers
Nov 15, 2023
moldy530
reviewed
Nov 15, 2023
moldy530
reviewed
Nov 15, 2023
avasisht23
force-pushed
the
11-08-feat_add_magic_signer_to_aa-signers
branch
from
November 17, 2023 00:45
bff022a
to
453555f
Compare
avasisht23
force-pushed
the
11-13-feat_add_web3auth_to_aa-signers
branch
from
November 17, 2023 00:45
514823f
to
c7110e2
Compare
moldy530
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a small bug in the docs, but LGTM otherwise
Merge activity
|
Base automatically changed from
11-08-feat_add_magic_signer_to_aa-signers
to
development
November 28, 2023 18:59
avasisht23
force-pushed
the
11-13-feat_add_web3auth_to_aa-signers
branch
from
November 28, 2023 19:00
c9279b1
to
9326842
Compare
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, see guidleines below)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:fix
)development
and notmain
?PR-Codex overview
This PR adds the
Web3AuthSigner
class to the@alchemy/aa-signers
package, which allows users to authenticate and interact with Web3Auth wallets. It also includes the necessary dependencies and documentation updates.Detailed summary
Web3AuthSigner
class to@alchemy/aa-signers
package@web3auth/modal
and@web3auth/base
)Web3AuthSigner
methods:getAddress
,signMessage
,signTypedData
,authenticate
,getAuthDetails