refactor: extend oauth authtype to support all providers #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7 tasks
rthomare
approved these changes
Oct 8, 2024
moldy530
force-pushed
the
moldy/redefine-oauth-authtype
branch
from
3fe8e1d to
9b51419
Compare
rthomare
pushed a commit
that referenced
this pull request
Oct 9, 2024
rthomare
added a commit
that referenced
this pull request
Oct 9, 2024
…s pr) (#1032) * chore: wip * chore: adds google social auth selection to sidebar and lint fixes * feat: authenticate with google, adds lint fixes * fix: remove divider between passkey and social auth sections * fix: adds temporary solution for forcing relaod to allow subsequent login attempts after logging out * fix: divider logic on component * chore: wip for oauth_completing step and oauth connection error * refactor: extend oauth authtype to support all providers (#1024) * fix: handle connection error * chore: extend account kit to be able to support other oauth methods * chore: add temp oauth connection error logo and util file to account-kit * chore: remove forced reload logout fix * chore: move hard coded strings into ls * chore: remove comments * fix: explicitly state that a KnownAuthProvider does not have a logoUrl * chore: add default handler for OAuth section * Update examples/ui-demo/src/app/state.tsx Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * refactor: put passkey and social auth in the same section * chore: add labels to known auth provider buttons, lint fixes * chore: add non-functional facebook button to sidebar and fix google icon size * chore: rebase onto master, fix conflicts, fix svg related errors * fix: handle the various types of authenticating (#1035) * refactor: cleanup the auth step usage (#1036) * chore: update sidebar oauth method button colors --------- Co-authored-by: linna <linna@alchemy.com> Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> Co-authored-by: Linna <38363056+linnall@users.noreply.github.com>
linnall
added a commit
that referenced
this pull request
Oct 10, 2024
* chore: wip * chore: adds google social auth selection to sidebar and lint fixes * feat: authenticate with google, adds lint fixes * fix: remove divider between passkey and social auth sections * fix: adds temporary solution for forcing relaod to allow subsequent login attempts after logging out * fix: divider logic on component * chore: wip for oauth_completing step and oauth connection error * refactor: extend oauth authtype to support all providers (#1024) * fix: handle connection error * chore: extend account kit to be able to support other oauth methods * chore: add temp oauth connection error logo and util file to account-kit * chore: remove forced reload logout fix * chore: move hard coded strings into ls * chore: remove comments * fix: explicitly state that a KnownAuthProvider does not have a logoUrl * chore: add default handler for OAuth section * Update examples/ui-demo/src/app/state.tsx Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * refactor: put passkey and social auth in the same section * chore: add labels to known auth provider buttons, lint fixes * chore: add non-functional facebook button to sidebar and fix google icon size * chore: rebase onto master, fix conflicts, fix svg related errors * fix: handle the various types of authenticating (#1035) * refactor: cleanup the auth step usage (#1036) * chore: update sidebar oauth method button colors * feat: enable facebook auth * fix: have connection error icon match chosen auth method * fix: use boolean --------- Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> Co-authored-by: Rohan Thomare <rohanthomare@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR enhances the social authentication feature by refining the configuration and type definitions for social logins, specifically integrating Google authentication with a popup mode. It also updates the component props and logic to support the new structure.
Detailed summary
state.tsx.authProviderIdandmodeinstate.tsx.createConfigfunction to enable popup OAuth based on the UI configuration.AuthTypetype to include detailed configurations for social authentication.OAuthcomponent props to acceptauthProviderIdinstead ofgoogleAuth.OAuth.tsxto display the Google login button based onauthProviderId.providers.tsxto align with the new authentication structure.