fix: updates facebook icon used in ui component #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
linnall
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
rthomare
approved these changes
Dec 12, 2024
moldy530
approved these changes
Dec 12, 2024
howydev
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix: rn stamper was returning stamp instead of response (#1201) * chore(release): publish v4.6.1 [skip-ci] * feat: add react-native-bare implementation (#1202) * feat: add react-native-bare implementation * fix: fix linting * fix: fix linting * fix: remove unnecessary console.log statements * feat: add signer and account addresses to user logged in screen * fix: updates facebook icon used in ui component (#1196) * feat: add mav2 signer (#1203) # Pull Request Checklist - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new `SingleSignerValidation` module and related utilities for signature packing and handling user operation signing. It enhances the smart contract framework by implementing various functions and defining the ABI for the module. ### Detailed summary - Added `PackSignatureParams` type and `packSignature` utility in `utils.ts`. - Created `SingleSignerValidationModule` with metadata and encoding functions in `single-signer-validation/module.ts`. - Implemented `singleSignerMessageSigner` function in `single-signer-validation/signer.ts` for signature management. - Defined the ABI for `singleSignerValidation` in `abis/singleSignerValidation.ts`. - Added `MAV2FactoryAbi` and `smaV2Abi` with functions and events related to account management in respective ABI files. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> Co-authored-by: Alchemy Bot <alchemy-bot@alchemy.com> Co-authored-by: Iyk Azorji <iykazorji@gmail.com>
howydev
pushed a commit
that referenced
this pull request
Dec 14, 2024
* fix: rn stamper was returning stamp instead of response (#1201) * chore(release): publish v4.6.1 [skip-ci] * feat: add react-native-bare implementation (#1202) * feat: add react-native-bare implementation * fix: fix linting * fix: fix linting * fix: remove unnecessary console.log statements * feat: add signer and account addresses to user logged in screen * fix: updates facebook icon used in ui component (#1196) * feat: add mav2 signer (#1203) # Pull Request Checklist - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new `SingleSignerValidation` module and related utilities for signature packing and handling user operation signing. It enhances the smart contract framework by implementing various functions and defining the ABI for the module. ### Detailed summary - Added `PackSignatureParams` type and `packSignature` utility in `utils.ts`. - Created `SingleSignerValidationModule` with metadata and encoding functions in `single-signer-validation/module.ts`. - Implemented `singleSignerMessageSigner` function in `single-signer-validation/signer.ts` for signature management. - Defined the ABI for `singleSignerValidation` in `abis/singleSignerValidation.ts`. - Added `MAV2FactoryAbi` and `smaV2Abi` with functions and events related to account management in respective ABI files. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> Co-authored-by: Alchemy Bot <alchemy-bot@alchemy.com> Co-authored-by: Iyk Azorji <iykazorji@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on updating the
FacebookLogocomponent to a newFacebookIconcomponent in theAuthenticationfeature. The new icon has a different design and size.Detailed summary
FacebookLogotoFacebookIconin theexamples/ui-demo/src/components/icons/facebook.tsx.FacebookIconwith a new SVG design and dimensions.Authenticationcomponent from<FacebookLogo />to<FacebookIcon />.