feat(aa-sdk): sdk light client can call the alchemy client #1236
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
| @@ -67,7 +86,7 @@ export function createLightAccountClient< | |||
| */ | |||
| export async function createLightAccountClient( | |||
| params: CreateLightAccountClientParams | |||
| ): Promise<SmartAccountClient> { | |||
| ): Promise<SmartAccountClient | AlchemySmartAccountClient> { | |||
| const { transport, chain } = params; | |||
|
|
|||
There was a problem hiding this comment.
I originally called something like this
But the code in
| if (isAlchemyTransport(transport)) { | |
| return await createLightAccountAlchemyClient({ | |
| ...params, | |
| transport, | |
| }); | |
| } | |
Since the code is the same?
Here is the snapshot of current alchemy client, I don't see a difference
There was a problem hiding this comment.
oh the difference is that this by default calls createSmartAccountClient and the alchemy calls createAlchemySmartAccountClient they take slightly different config params (createSCAClient takes in a paymasterMiddleware and createAlchemySCAClient takes in a gasManagerConfig or I think just a policyId)
There was a problem hiding this comment.
Okay, I'll go down the side of testing the params to check the transport as alchemyTransport
| params: AlchemyLightAccountClientConfig<TSigner> | ||
| ): Promise< | ||
| AlchemySmartAccountClient< | ||
| Chain | undefined, | ||
| LightAccount<TSigner>, | ||
| LightAccountClientActions<TSigner> | ||
| > | ||
| >; |
There was a problem hiding this comment.
oh nice! this is way cleaner than what I was thinking which was adding to the conditional typing in for CreateLightAccountClientParams based on the transport
There was a problem hiding this comment.
Had to verify this, and slight variation. Good thing for tests right?
Blu-J
force-pushed
the
jade/poc-same-client
branch
from
f41c381 to
6ebfca5
Compare
Blu-J
force-pushed
the
jade/poc-same-client
branch
from
59af47f to
cca9ba3
Compare
Blu-J
requested review from
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on enhancing the
createLightAccountClientfunction to supportAlchemyTransport, modifying its return type accordingly, and introducing theisAlchemyTransportutility function.Detailed summary
createLightAccountClientto acceptAlchemyTransport.AlchemySmartAccountClientwhen usingAlchemyTransport.isAlchemyTransportfunction to check transport type.