-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add expo otp example #1243
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
d083b22
to
4cbfa9b
Compare
dec3edc
to
99a2576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the formatting on this is wild, is prettier not running on this folder?
return ( | ||
<Tabs screenOptions={{ tabBarActiveTintColor: "blue" }}> | ||
<Tabs.Screen | ||
name="index" // Magic Link Auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't the redirect server go to magic-link
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no expo-router
needs each folder to have an index.tsx as the default route. In this case we are using the default route as the magic-link example
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on refactoring the navigation structure of a React Native Expo application, enhancing the authentication flow with new screens for Magic Link and OTP authentication, and improving the UI components for user interaction.
Detailed summary
Slot
toStack
inapp/_layout.tsx
.TabLayout
with two new tabs: "Magic Link" and "OTP Auth" inapp/(tabs)/_layout.tsx
.HomeScreen
toMagicLinkAuthScreen
and updated authentication logic inapp/(tabs)/index.tsx
.OTPAuthScreen
with email and OTP authentication inapp/(tabs)/otp-auth.tsx
.TextInput
andTouchableOpacity
for user input and actions.