Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expo otp example #1243

Merged
merged 7 commits into from
Jan 7, 2025
Merged

feat: add expo otp example #1243

merged 7 commits into from
Jan 7, 2025

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Dec 19, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on refactoring the navigation structure of a React Native Expo application, enhancing the authentication flow with new screens for Magic Link and OTP authentication, and improving the UI components for user interaction.

Detailed summary

  • Changed the main layout from Slot to Stack in app/_layout.tsx.
  • Introduced TabLayout with two new tabs: "Magic Link" and "OTP Auth" in app/(tabs)/_layout.tsx.
  • Renamed HomeScreen to MagicLinkAuthScreen and updated authentication logic in app/(tabs)/index.tsx.
  • Added OTPAuthScreen with email and OTP authentication in app/(tabs)/otp-auth.tsx.
  • Enhanced UI with TextInput and TouchableOpacity for user input and actions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 11:43pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 11:43pm

Copy link
Collaborator Author


How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iykazrji iykazrji force-pushed the iyk/update-otp-expo-example branch from dec3edc to 99a2576 Compare December 20, 2024 17:44
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting on this is wild, is prettier not running on this folder?

return (
<Tabs screenOptions={{ tabBarActiveTintColor: "blue" }}>
<Tabs.Screen
name="index" // Magic Link Auth
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the redirect server go to magic-link?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no expo-router needs each folder to have an index.tsx as the default route. In this case we are using the default route as the magic-link example

@iykazrji iykazrji merged commit 30d6443 into main Jan 7, 2025
7 checks passed
@iykazrji iykazrji deleted the iyk/update-otp-expo-example branch January 7, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants