docs: update the magic docs to highlight signer creation is async #170
Conversation
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
| export const magicClient = createWalletClient({ | ||
| transport: custom(magic.rpcProvider), |
There was a problem hiding this comment.
this one doesn't work? did not look into magic code, but why is getting rpc provider async here?
hmm, and just using rpcProvider field directly seems to work fine on examples I tried.
There was a problem hiding this comment.
yea I'm not sure why this didn't work for a customer... maybe it was because you have to authenticate with a user first?
lemme take another pass at this and make it even more clear that authentication is required first
There was a problem hiding this comment.
in the unauthed case .rpcProvider was returning undefined
There was a problem hiding this comment.
hmm I didn't need to do this if I mapped the magicClient to any for the new WalletClientSigner below:
|
needs to be async because the method to auth with magic is async. if you don't auth first then you get errors when connecting the account and using it. to make it simpler, I think we should just recommend that people auth first before connecting |
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
PR-Codex overview
Detailed summary
This PR focuses on updating the
magicSignerimport and usage in the code. The notable changes include:magicSignertocreateMagicSignerownerassignment to useawait createMagicSigner()instead ofmagicSignercreateMagicSignerthat authenticates the user and creates aWalletClientSignerobject using themagicSDK andmagicClient