chore: nit updates to use Promise all and helper methods for readability #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswon
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
avasisht23
as code owners
avasisht23
reviewed
Nov 5, 2023
| @@ -405,7 +405,7 @@ export class SmartAccountProvider< | |||
| // this pretty prints the uo | |||
| throw new Error( | |||
| `Request is missing parameters. All properties on UserOperationStruct must be set. uo: ${JSON.stringify( | |||
| request, | |||
| uoStruct, | |||
There was a problem hiding this comment.
was there a reason not to use request here?
There was a problem hiding this comment.
thought hex is less readable, because users will identify numbers better.
avasisht23
approved these changes
Nov 5, 2023
Merged
moldy530
pushed a commit
that referenced
this pull request
Nov 10, 2023
denniswon
added a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
Focus of the PR:
This PR focuses on improving error handling and setting the
maxPriorityFeePerGasBidvalue in the SmartAccountProvider class.Detailed summary:
bigIntMaxfunction inbigint.tsto throw an error if no arguments are provided.base.tsto include theuoStructparameter.feeDataGetterfunction inbase.tsto usebigIntMaxfunction and handle error cases more effectively.