Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove AA_SDK_TESTS_SIGNER_TYPE constant exported from aa-core #232

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: remove AA_SDK_TESTS_SIGNER_TYPE constant exported from aa-core #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/accounts/src/kernel-zerodev/__tests__/mocks/mock-signer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ import type {
SignTypedDataParams,
SmartAccountSigner,
} from "@alchemy/aa-core";
import { AA_SDK_TESTS_SIGNER_TYPE } from "@alchemy/aa-core";

export class MockSigner implements SmartAccountSigner {
inner: any;

signerType = AA_SDK_TESTS_SIGNER_TYPE;
signerType = "aa-sdk-tests";

getAddress(): Promise<Address> {
return Promise.resolve("0x48D4d3536cDe7A257087206870c6B6E76e3D4ff4");
Expand Down
3 changes: 1 addition & 2 deletions packages/accounts/src/kernel-zerodev/e2e-tests/kernel-account.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
AA_SDK_TESTS_SIGNER_TYPE,
getDefaultEntryPointAddress,
type BatchUserOperationCallData,
type SmartAccountSigner,
Expand Down Expand Up @@ -39,7 +38,7 @@ describe("Kernel Account Tests", () => {
const ownerAccount = mnemonicToAccount(OWNER_MNEMONIC);
const owner: SmartAccountSigner<HDAccount> = {
inner: ownerAccount,
signerType: AA_SDK_TESTS_SIGNER_TYPE,
signerType: "aa-sdk-tests",
signMessage: async (msg) =>
ownerAccount.signMessage({
message: { raw: toHex(msg) },
Expand Down
3 changes: 1 addition & 2 deletions packages/accounts/src/kernel-zerodev/e2e-tests/mocks/mock-signer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
AA_SDK_TESTS_SIGNER_TYPE,
type Address,
type Hex,
type SignTypedDataParams,
Expand All @@ -11,7 +10,7 @@ import { OWNER_MNEMONIC } from "../constants.js";
export class MockSigner implements SmartAccountSigner<HDAccount> {
inner = mnemonicToAccount(OWNER_MNEMONIC);

signerType = AA_SDK_TESTS_SIGNER_TYPE;
signerType = "aa-sdk-tests";

getAddress(): Promise<Address> {
return Promise.resolve("0x48D4d3536cDe7A257087206870c6B6E76e3D4ff4");
Expand Down
3 changes: 1 addition & 2 deletions packages/accounts/src/kernel-zerodev/validator/__tests__/mocks/mock-signer-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
AA_SDK_TESTS_SIGNER_TYPE,
type Address,
type Hex,
type SignTypedDataParams,
Expand All @@ -9,7 +8,7 @@ import {
export class MockSignerValidator implements SmartAccountSigner {
inner: any;

signerType = AA_SDK_TESTS_SIGNER_TYPE;
signerType = "aa-sdk-tests";

signTypedData(_params: SignTypedDataParams): Promise<`0x${string}`> {
return Promise.resolve("0xMOCK_SIGN_TYPED_DATA");
Expand Down
3 changes: 1 addition & 2 deletions packages/alchemy/e2e-tests/simple-account.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {
SimpleSmartContractAccount,
getDefaultSimpleAccountFactoryAddress,
type SmartAccountSigner,
AA_SDK_TESTS_SIGNER_TYPE,
} from "@alchemy/aa-core";
import { Alchemy, Network } from "alchemy-sdk";
import { toHex, type Address, type Chain, type Hash } from "viem";
Expand All @@ -23,7 +22,7 @@ describe("Simple Account Tests", () => {
}),
signTypedData: async () => "0xHash",
getAddress: async () => ownerAccount.address,
signerType: AA_SDK_TESTS_SIGNER_TYPE,
signerType: "aa-sdk-tests",
};

it("should successfully get counterfactual address", async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/alchemy/src/__tests__/provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe("Alchemy Provider Tests", () => {
}),
signTypedData: async () => "0xHash",
getAddress: async () => ownerAccount.address,
signerType: AACoreModule.AA_SDK_TESTS_SIGNER_TYPE,
signerType: "aa-sdk-tests",
};
const chain = polygonMumbai;

Expand Down
1 change: 0 additions & 1 deletion packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export type {
SmartAccountSigner,
SmartAccountAuthenticator,
} from "./signer/types.js";
export { AA_SDK_TESTS_SIGNER_TYPE } from "./signer/types.js";
export {
verifyEIP6492Signature,
wrapSignatureWith6492,
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/signer/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,3 @@ export interface SmartAccountSigner<Inner = any> {

signTypedData: (params: SignTypedDataParams) => Promise<Hex>;
}

export const AA_SDK_TESTS_SIGNER_TYPE = "aa-sdk-tests";
Loading