Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: paymasterAndData override to skip paymaster middleware #236

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat: paymasterAndData override to skip paymaster middleware #236

merged 1 commit into from
Nov 10, 2023

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Nov 10, 2023 •
edited by pr-codex bot
Loading

https://alchemyinsights.slack.com/archives/C04RHSDSP9U/p1699576887233839

https://app.asana.com/0/1205598840815267/1205892709620241/f

PR-Codex overview

Detailed summary

  • The focus of this PR is to refactor the base.ts file in the core package.
  • Notable changes include:
    • Replacing the paymasterDataMiddleware function with overrides.paymasterAndData if it exists, otherwise using noOpMiddleware.
    • Updating the function call to include the new middleware.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@denniswon denniswon force-pushed the denniswon/send-user-op-paymaster branch from e58a52c to 74e769a Compare November 10, 2023 17:05
@denniswon denniswon changed the title feat: if paymasterAndData override exists then skip paymaster middleware during the middleware pipeline run feat: paymasterAndData override to skip paymaster middleware Nov 10, 2023
@denniswon denniswon closed this Nov 10, 2023
@denniswon denniswon reopened this Nov 10, 2023
@denniswon denniswon merged commit 5222952 into development Nov 10, 2023
5 of 6 checks passed
@denniswon denniswon deleted the denniswon/send-user-op-paymaster branch November 10, 2023 17:10
avasisht23 pushed a commit that referenced this pull request Nov 14, 2023
@denniswon @avasisht23
feat: paymasterAndData override to skip paymaster middleware (#236)
c7235fb
@moldy530 moldy530 mentioned this pull request Nov 17, 2023
Merged
7 tasks
@moldy530 moldy530 mentioned this pull request Dec 1, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avasisht23 avasisht23 avasisht23 approved these changes

@moldy530 moldy530 Awaiting requested review from moldy530 moldy530 is a code owner

@rthomare rthomare Awaiting requested review from rthomare rthomare is a code owner

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@mokok123 mokok123 Awaiting requested review from mokok123 mokok123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniswon @avasisht23