docs: update CONTRIBUTING guide, fix PR template, and clean up README #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SahilAujla
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
avasisht23
approved these changes
Nov 29, 2023
README.md
Outdated
|
|
||
| The SDK also implements an EIP-1193 provider interface to easily plug into any popular dapp or wallet connect libraries such as RainbowKit, Wagmi, and Web3Modal. It also includes ethers.js adapters to provide full support for ethers.js apps. | ||
|
|
||
| The `aa-sdk` is modular at every layer of the stack and can be easily extended to fit your custom needs. You can plug in any [smart account](https://accountkit.alchemy.com/smart-accounts/accounts/using-your-own) implementation, [Signer](https://accountkit.alchemy.com/smart-accounts/signers/overview), [Gas Manager API](https://accountkit.alchemy.com/overview/introduction.html#gas-manager-api), RPC provider. | ||
| The `aa-sdk` is modular at every layer of the stack and can be easily extended to fit your custom needs. You can plug in any [smart account](https://accountkit.alchemy.com/smart-accounts/accounts/using-your-own) implementation, [Signer](https://accountkit.alchemy.com/smart-accounts/signers/overview), Gas Manager API and RPC Provider. |
There was a problem hiding this comment.
hyperlink to gas manager docs?
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
…#290) * docs: update CONTRIBUTING guide, fix PR template, and clean up README * Update CONTRIBUTING.md Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com> * Update README.md Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com> * docs: make requested changes --------- Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
…#290) * docs: update CONTRIBUTING guide, fix PR template, and clean up README * Update CONTRIBUTING.md Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com> * Update README.md Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com> * docs: make requested changes --------- Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates the pull request checklist and adds more detailed instructions in the README and CONTRIBUTING.md files.
Detailed summary