feat: msca plugingen to generate subfolders for each plugin #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswon
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
avasisht23
as code owners
moldy530
approved these changes
Jan 5, 2024
denniswon
force-pushed
the
denniswon/msca-plugingen-out
branch
from
9422b31 to
3c77b42
Compare
moldy530
pushed a commit
that referenced
this pull request
Jan 8, 2024
moldy530
added a commit
that referenced
this pull request
Jan 8, 2024
* feat: add some plugin generation logic (#262) * feat: add some plugin generation logic * chore: add generate commands * style: apply PR suggestion Co-authored-by: Dennis Won <denniswon@users.noreply.github.com> * refactor: create plugin config concept * feat: add multi-owner-msca impl that leverages the plugin gen (#263) * feat: add multi-owner-msca impl that leverages the plugin gen * feat: proposal for msca builder pattern (#264) * feat: proposal for msca builder pattern * refactor: rework plugin gen to create read methods for the account --------- Co-authored-by: Dennis Won <denniswon@users.noreply.github.com> * chore: lint * feat: add plugin manager decorator for MSCA (#274) * feat: add initial skeleton for 6900 account support * feat: add some plugin generation logic (#262) * feat: add some plugin generation logic * chore: add generate commands * style: apply PR suggestion Co-authored-by: Dennis Won <denniswon@users.noreply.github.com> * refactor: create plugin config concept * feat: add multi-owner-msca impl that leverages the plugin gen (#263) * feat: add multi-owner-msca impl that leverages the plugin gen * feat: proposal for msca builder pattern (#264) * feat: proposal for msca builder pattern * refactor: rework plugin gen to create read methods for the account --------- Co-authored-by: Dennis Won <denniswon@users.noreply.github.com> * chore: update plugin gen * feat: add plugin manager decorator for MSCA * feat: add a mechanism for adding provider decorators to accounts (#287) * feat: add a mechanism for adding provider decorators to accounts * chore: update lerna and package json to lint generated files * refactor: rename MSCA to IMSCA --------- Co-authored-by: Dennis Won <denniswon@users.noreply.github.com> Co-authored-by: avasisht23 <ajay@alchemy.com> * fix: missed some plugingen fixes * refactor: change the names of the plugin decorators and add example usages (#308) * feat: extend msca account with account loupe decorators (#309) * refactor: move required by types to aa-core utils types folder * feat: extend msca account with account loupe decorators * feat: move extend method on account from msca to base account * Update packages/core/src/account/types.ts Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * Update packages/core/src/account/types.ts Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * Update packages/core/src/account/types.ts Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * Update packages/accounts/src/msca/account-loupe/decorator.ts Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * fix: fix lint and build --------- Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * fix: update the logic for signing 1271 messages * feat: msca plugingen to accept multichain address format (#314) * feat: msca plugingen to accept multichain address format * Update packages/accounts/scripts/plugingen.ts Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * Update packages/accounts/wagmi.config.ts Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * feat: changed address field in plugingenconfig to addresses --------- Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com> * feat: msca token receiver plugin with opt out option to exclude default token receiver plugin (#316) * feat: msca plugingen to accept multichain address format * feat: msca token receiver plugin with opt out option to exclude default token receiver plugin * feat: add session key plugin abi and plugingen (#284) * feat: msca plugingen to accept multichain address format * feat: msca token receiver plugin with opt out option to exclude default token receiver plugin * feat: msca token receiver plugin with opt out option to exclude default token receiver plugin * feat: add session key plugin abi and plugingen * feat: msca plugin provider decorator to support user op overrides (#342) * feat: msca plugingen to generate subfolders for each plugin (#350) --------- Co-authored-by: Dennis Won <denniswon@users.noreply.github.com> Co-authored-by: avasisht23 <ajay@alchemy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
Focus of this PR:
This PR focuses on refactoring the import paths for plugins in the
accountspackage.Detailed summary:
wagmi.config.ts,plugingen.ts, andmsca/multi-owner-account.tsfiles.PluginandIMSCAtypes in plugin files.ISmartAccountProviderand other types in plugin files.