Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alchemy-signer): missing transports on iOS during passkey creation #488

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Feb 26, 2024

Pull Request Checklist


PR-Codex overview

The focus of this PR is to handle cases where attestation.transports is empty or null on iOS by assigning default values.

Detailed summary

  • Handle cases where attestation.transports is empty or null on iOS
  • Assign default values to attestation.transports if necessary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

// on iOS sometimes this is returned as empty or null, so handling that here
if (attestation.transports == null || attestation.transports.length === 0) {
attestation.transports = [
"AUTHENTICATOR_TRANSPORT_INTERNAL",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { TurnkeyClient, getWebAuthnAttestation } from "@turnkey/http";

this is returning the attestation. is this their SDK issue for not handling ios?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this is something they should handle imo, but I wanna unblock dubz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moldy530 moldy530 merged commit 740946f into main Feb 26, 2024
2 checks passed
@moldy530 moldy530 deleted the moldy/fix-missin-transports branch February 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants