fix(alchemy-signer): allow for org id to be passed with bundle #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
dphilipson
approved these changes
Mar 9, 2024
dphilipson
reviewed
Mar 9, 2024
| @@ -214,7 +216,10 @@ export class AlchemySigner | |||
| }); | |||
| }); | |||
| } else { | |||
| const temporarySession = this.sessionManager.getTemporarySession(); | |||
| const temporarySession = params.orgId | |||
There was a problem hiding this comment.
Does this change mean the org id no longer needs to be kept in storage for new magic links?
There was a problem hiding this comment.
yea exactly, but I left it for now to be backwards compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces the ability to include
redirectParamsin various parts of the Alchemy Signer codebase.Detailed summary
redirectParamshandling inSignerClientandSignerclassesSignerClientandSignerforredirectParamsSignerEndpointstypes to handleredirectParamsAuthParamstype to includeredirectParamsandorgIdoptions