Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating import in eoa guide #525

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix: updating import in eoa guide #525

merged 2 commits into from
Mar 21, 2024

Conversation

avarobinson
Copy link
Collaborator

@avarobinson avarobinson commented Mar 20, 2024

Pull Request Checklist


PR-Codex overview

This PR updates the import statements in site/signers/eoa.md to include WalletClientSigner from the @alchemy/aa-core package.

Detailed summary

  • Updated import statements to include WalletClientSigner from @alchemy/aa-core package.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Comment on lines 35 to 36
import { mainnet } from "@alchemy/aa-core";
import { WalletClientSigner } from "@alchemy/core";
import { WalletClientSigner } from "@alchemy/aa-core";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch. you can join these lines to import both since it's the same package

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops silly oversight

avasisht23
avasisht23 previously approved these changes Mar 20, 2024
Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, then 🚢 🙏

@avarobinson avarobinson merged commit 6c1c28f into main Mar 21, 2024
2 checks passed
@avarobinson avarobinson deleted the ava/fix-guide branch March 21, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants