Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds streamlined quick start #697

Merged
merged 24 commits into from
Jun 6, 2024
Merged

Conversation

Dan-Nolan
Copy link
Collaborator

@Dan-Nolan Dan-Nolan commented Jun 3, 2024

Pull Request Checklist


PR-Codex overview

This PR adds submodules, updates Node.js setup, and enhances the Embedded Accounts quickstart guide with new sections and content.

Detailed summary

  • Added submodules for recursive fetching
  • Updated Node.js setup
  • Enhanced Embedded Accounts quickstart guide with new sections and content

The following files were skipped due to too many changes: site/pages/getting-started/walkthrough.mdx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

First, let's do our configuration in a single file called `config.ts`.

```ts [config.ts]
// [!include ~/../examples/embedded-accounts-quickstart/src/config.ts:create-accounts-config]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the create-accounts-config section render correctly? I can't remember if I had issues with region names that were kebab cased

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it works! I actually thought it was kebab casing for a minute, but I had to change the region comments in the aa-sdk repo. After that it worked fine ✅

moldy530
moldy530 previously approved these changes Jun 3, 2024
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM had one question about region names, but I think my issue was different

@moldy530
Copy link
Collaborator

moldy530 commented Jun 3, 2024

ah wait

./how-it-works.md in /home/runner/work/aa-sdk/aa-sdk/site/pages/getting-started/run-locally.mdx
./run-the-app.md in /home/runner/work/aa-sdk/aa-sdk/site/pages/getting-started/introduction.mdx
./how-it-works.md in /home/runner/work/aa-sdk/aa-sdk/site/pages/getting-started/introduction.mdx

you need to drop the extension on those files so they get rendered correctly

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 7:59pm

@Dan-Nolan
Copy link
Collaborator Author

good call, fixed the link extensions!

@Dan-Nolan
Copy link
Collaborator Author

actually, scratch that, the relative linking is off by one... 🤔

@Dan-Nolan
Copy link
Collaborator Author

checked all the links, working well ✅

@moldy530 moldy530 force-pushed the vocs-docs branch 5 times, most recently from 4587b19 to f2be161 Compare June 4, 2024 20:48
@moldy530
Copy link
Collaborator

moldy530 commented Jun 4, 2024

you might need to rebase on top of vocs-docs

@moldy530 moldy530 force-pushed the vocs-docs branch 2 times, most recently from e9bd3e9 to ba19b68 Compare June 5, 2024 16:07
tinaszheng and others added 15 commits June 6, 2024 13:10
* run store hydration on window focus

* remove logs
* feat: update button colors

* fix: update test
* fix: allow nonzero paymaster override

* refactor: update to use Hex type for paymasterAndData/paymasterData override

* fix: add checks for paymasterData and paymaster field nonzero overrides

* fix: add paymaster address override type

* feat: gas manager only bypasses paymaster middleware when the UserOp paying for its own gas

* fix: add signatures and overrides to fix 3/3 msig test and add paymaster test
* feat: switch type => variant and use type submit

* fix: add custom focus state
* feat: add error boundary by id

* fix: remove unused classnames

* feat: use error from hook

* fix: remove unused variables

* fix: remove console log

* fix: add new colors to test

* feat: rename to useAuthError
* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: add vercel json

* docs: add build script

* docs: add rewrites for .html`

* docs: try cleanUrls

* docs: remove rewrites

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>
@moldy530 moldy530 merged commit b7cf8b8 into vocs-docs Jun 6, 2024
5 checks passed
@moldy530 moldy530 deleted the dn/streamlined-quickstart branch June 6, 2024 20:25
moldy530 added a commit that referenced this pull request Jun 6, 2024
* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: adds streamlined quick start

* docs: drops the file extension on local quick start links

* docs: fix relative routes across quick start

* feat: run store hydration on window focus (#695)

* run store hydration on window focus

* remove logs

* feat: update button colors (#696)

* feat: update button colors

* fix: update test

* fix: plugins were missing mainnet config (#692)

* fix: account hydration was missing state (#693)

* chore: enable version syncing when publishing (#694)

* chore(release): publish v3.18.0 [skip-ci]

* fix: fix paymaster override for multisig plugin (#676)

* fix: allow nonzero paymaster override

* refactor: update to use Hex type for paymasterAndData/paymasterData override

* fix: add checks for paymasterData and paymaster field nonzero overrides

* fix: add paymaster address override type

* feat: gas manager only bypasses paymaster middleware when the UserOp paying for its own gas

* fix: add signatures and overrides to fix 3/3 msig test and add paymaster test

* chore: rename button "type" to "variant"  (#699)

* feat: switch type => variant and use type submit

* fix: add custom focus state

* fix: update the version of the store so that we don't have clashes (#703)

* chore(release): publish v3.18.1 [skip-ci]

* chore(release): publish v3.18.2 [skip-ci]

* feat: add updated error UI + custom error rendering  (#705)

* feat: add error boundary by id

* fix: remove unused classnames

* feat: use error from hook

* fix: remove unused variables

* fix: remove console log

* fix: add new colors to test

* feat: rename to useAuthError

* docs: add vercel json (#700)

* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: add vercel json

* docs: add build script

* docs: add rewrites for .html`

* docs: try cleanUrls

* docs: remove rewrites

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>

* chore: remove the docs publishing github action

* docs: run locally meets dashboard quickstart

* chore: update the gh actions to checkout submodules

* chore: add embedded accounts submodule

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>
Co-authored-by: Tina <59578595+tinaszheng@users.noreply.github.com>
Co-authored-by: Alchemy Bot <alchemy-bot@alchemy.com>
Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>
Co-authored-by: Cody McCabe <cmccabe524@gmail.com>
moldy530 added a commit that referenced this pull request Jun 13, 2024
* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: adds streamlined quick start

* docs: drops the file extension on local quick start links

* docs: fix relative routes across quick start

* feat: run store hydration on window focus (#695)

* run store hydration on window focus

* remove logs

* feat: update button colors (#696)

* feat: update button colors

* fix: update test

* fix: plugins were missing mainnet config (#692)

* fix: account hydration was missing state (#693)

* chore: enable version syncing when publishing (#694)

* chore(release): publish v3.18.0 [skip-ci]

* fix: fix paymaster override for multisig plugin (#676)

* fix: allow nonzero paymaster override

* refactor: update to use Hex type for paymasterAndData/paymasterData override

* fix: add checks for paymasterData and paymaster field nonzero overrides

* fix: add paymaster address override type

* feat: gas manager only bypasses paymaster middleware when the UserOp paying for its own gas

* fix: add signatures and overrides to fix 3/3 msig test and add paymaster test

* chore: rename button "type" to "variant"  (#699)

* feat: switch type => variant and use type submit

* fix: add custom focus state

* fix: update the version of the store so that we don't have clashes (#703)

* chore(release): publish v3.18.1 [skip-ci]

* chore(release): publish v3.18.2 [skip-ci]

* feat: add updated error UI + custom error rendering  (#705)

* feat: add error boundary by id

* fix: remove unused classnames

* feat: use error from hook

* fix: remove unused variables

* fix: remove console log

* fix: add new colors to test

* feat: rename to useAuthError

* docs: add vercel json (#700)

* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: add vercel json

* docs: add build script

* docs: add rewrites for .html`

* docs: try cleanUrls

* docs: remove rewrites

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>

* chore: remove the docs publishing github action

* docs: run locally meets dashboard quickstart

* chore: update the gh actions to checkout submodules

* chore: add embedded accounts submodule

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>
Co-authored-by: Tina <59578595+tinaszheng@users.noreply.github.com>
Co-authored-by: Alchemy Bot <alchemy-bot@alchemy.com>
Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>
Co-authored-by: Cody McCabe <cmccabe524@gmail.com>
moldy530 added a commit that referenced this pull request Jun 13, 2024
* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: add vercel json (#700)

* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: add vercel json

* docs: add build script

* docs: add rewrites for .html`

* docs: try cleanUrls

* docs: remove rewrites

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>

* chore: remove the docs publishing github action

* docs: adds streamlined quick start (#697)

* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: adds streamlined quick start

* docs: drops the file extension on local quick start links

* docs: fix relative routes across quick start

* feat: run store hydration on window focus (#695)

* run store hydration on window focus

* remove logs

* feat: update button colors (#696)

* feat: update button colors

* fix: update test

* fix: plugins were missing mainnet config (#692)

* fix: account hydration was missing state (#693)

* chore: enable version syncing when publishing (#694)

* chore(release): publish v3.18.0 [skip-ci]

* fix: fix paymaster override for multisig plugin (#676)

* fix: allow nonzero paymaster override

* refactor: update to use Hex type for paymasterAndData/paymasterData override

* fix: add checks for paymasterData and paymaster field nonzero overrides

* fix: add paymaster address override type

* feat: gas manager only bypasses paymaster middleware when the UserOp paying for its own gas

* fix: add signatures and overrides to fix 3/3 msig test and add paymaster test

* chore: rename button "type" to "variant"  (#699)

* feat: switch type => variant and use type submit

* fix: add custom focus state

* fix: update the version of the store so that we don't have clashes (#703)

* chore(release): publish v3.18.1 [skip-ci]

* chore(release): publish v3.18.2 [skip-ci]

* feat: add updated error UI + custom error rendering  (#705)

* feat: add error boundary by id

* fix: remove unused classnames

* feat: use error from hook

* fix: remove unused variables

* fix: remove console log

* fix: add new colors to test

* feat: rename to useAuthError

* docs: add vercel json (#700)

* docs: revert revert to use vocs for docs

* docs: address some of the broken things on the site (#689)

* docs: update the logos for AK

* docs: add vercel json

* docs: add build script

* docs: add rewrites for .html`

* docs: try cleanUrls

* docs: remove rewrites

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>

* chore: remove the docs publishing github action

* docs: run locally meets dashboard quickstart

* chore: update the gh actions to checkout submodules

* chore: add embedded accounts submodule

---------

Co-authored-by: moldy <michael.moldoveanu@alchemy.com>
Co-authored-by: Tina <59578595+tinaszheng@users.noreply.github.com>
Co-authored-by: Alchemy Bot <alchemy-bot@alchemy.com>
Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>
Co-authored-by: Cody McCabe <cmccabe524@gmail.com>

---------

Co-authored-by: Cody McCabe <cmccabe524@gmail.com>
Co-authored-by: Dan Nolan <dan.nolan@alchemy.com>
Co-authored-by: Tina <59578595+tinaszheng@users.noreply.github.com>
Co-authored-by: Alchemy Bot <alchemy-bot@alchemy.com>
Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants