-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect OS or root class for dark mode #759
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"@media (prefers-color-scheme: dark) { &:not(.light, .light *) }", | ||
"&:is(.dark, .dark *)", | ||
], | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is above the ...config
so that the client apps can override it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this also mean that dark mode must be enabled using the dark
class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it handles both! so the OS preference or the class-based approach will work
5cca699
to
16d9c97
Compare
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR introduces a light theme to the UI demo, adds dark mode support to Tailwind CSS, and updates the UI to toggle between light and dark themes.
Detailed summary