-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aa-sdk/core): add erc7677 middleware #823
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TODO:
|
34b046e
to
7dd77b7
Compare
7dd77b7
to
f0b8607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a question inline.
f0b8607
to
e6bd4ee
Compare
ae18dd6
to
f67fecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Parameters: [UserOperationRequest, Address, Hex, Record<string, any>]; | ||
ReturnType: { | ||
sponsor?: { name: string; icon?: string }; // Sponsor info | ||
paymaster?: Hex; // Paymaster address (entrypoint v0.7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the nit, but for clarity it might be better to use Address
for paymaster
here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good! yea I'll update this
f67fecf
to
49753f2
Compare
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
The focus of this PR is to introduce a new middleware function
erc7677Middleware
and update related imports and configurations.Detailed summary
erc7677Middleware
function for interacting with ERC-7677 enabled clients