-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add allowlist module #912
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -10,8 +12,10 @@ const meta = { | |||
addresses, | |||
}; | |||
|
|||
// Todo: some unified type for ERC-6900 v0.8 modules. I couldn't figure out how to parameterize the class itself over the abi type parameters for onInstall and onUninstall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain this? what's your ideal devex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is just a todo for later, but basically it'd be nice to have a base "class" or other util for creating module definitions that just takes in:
- An address record
- Name / meta info
- The parameter formats for
onInstall
/onUninstall
And it could produce something that fits the interface I created and have been using so far. I don't think it needs to be as heavyweight as the old plugingen, since most config formats are now off-chain rather than in the manifest, but it would be nice to have an enforced interface / type for the modules.
* feat: add allowlist module and tests * test: increase timeout
* feat: add allowlist module and tests * test: increase timeout
* feat: add allowlist module and tests * test: increase timeout
Add the AllowlistModule from the ERC-6900 reference implementation as a built-in module.
Provide a fork test that uses the allowlist module as a pre-validation hook over a SingleSignerValidation key.
Update the exports in
@account-kit/smart-contracts
to:AccountLoupeV08Actions
andInstallValidationActions
.HookType
, not just the type.Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
The focus of this PR is to add two new modules,
SingleSignerValidationModule
andAllowlistModule
, along with their ABIs and tests.Detailed summary
SingleSignerValidationModule
with ABI and encode functionsAllowlistModule
with ABI and encode functionsindex.ts
for new modules