Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add personal_ to disallow prefix #111

Merged
merged 2 commits into from
Mar 16, 2022
Merged

add personal_ to disallow prefix #111

merged 2 commits into from
Mar 16, 2022

Conversation

thebrianchen
Copy link
Member

Fixes #62.

Turns out we're forwarding calls prefixed with personal_ to the Alchemy provider, when they should instead be handled instead by the default writer provider. This PR makes forwards all calls prefixed with personal_ to the write provider, since Alchemy does not support them.

@thebrianchen thebrianchen requested a review from dphilipson March 15, 2022 20:53
Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thebrianchen thebrianchen merged commit 21d823c into master Mar 16, 2022
@thebrianchen thebrianchen deleted the bc/disallow-prefix branch March 16, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3.eth.personal.ecRecover calls alchemy & returns uncaught Error 400 undefined
2 participants