Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contractAddress property on TokenBalanceSuccess and TokenBalanceFailure #118

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix contractAddress property on TokenBalanceSuccess and TokenBalanceFailure #118

merged 1 commit into from
Apr 11, 2022

Conversation

thebrianchen
Copy link
Member

Fixes #116.

Small naming correction. Verified response property name is contractAddress after testing the endpoint.

@thebrianchen thebrianchen requested a review from omarsayha April 7, 2022 19:55
omarsayha
omarsayha approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@omarsayha omarsayha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing 🙏🏼

@thebrianchen thebrianchen merged commit f6d342e into master Apr 11, 2022
@thebrianchen thebrianchen deleted the bc/fix-token-balance-type branch April 11, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarsayha omarsayha omarsayha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property 'contractAddress' does not exist on type 'TokenBalance'
2 participants
@thebrianchen @omarsayha