feat: Deploy v1.0.0 #139
feat: Deploy v1.0.0 #139
Conversation
There was a problem hiding this comment.
Curious why there are two for sepolia
There was a problem hiding this comment.
At first I ran the script regularly, and it tried to submit all of the transactions at once. However, on the RPC side it didn't want to accept the 4th and 5th transactions (staking the factory and deploying SessionKeyPlugin) because the nonce was too far ahead, so it caused an error and the script stopped. I had to re-run the script after setting the env vars for the existing deployed addresses.
For all of the other networks, I used the --slow option (docs here), which delays sending the transaction until the previous one is confirmed. This prevented the too many pending transactions error that I ran into with Sepolia, and keep a single run of the script in the broadcast folder. I should document this behavior for the future.
deployments/mainnets/Arbitrum.md
Outdated
There was a problem hiding this comment.
I like this change of tracking deployments this way.
Thoughts on following Alchemy's convention of naming for the chain-networks for the filenames and maybe making the structure flatter? For example:
deployments/arb-mainnet.md
deployments/eth-goerli.md
deployments/polygon-mainnet.md
There was a problem hiding this comment.
renamed the files the Alchemy naming convention, for now I kept the split between testnets and mainnets but we can drop that in the future if we'd like.
Commit the deployment artifacts from v1.0.0 to
/deployments.Uses the LightAccount deployment tracker format, except on a per-network basis. This provides more context than JSON, by noting the salt and script run artifact, as well as providing an explorer link for convenience. We should revisit this tracking format if we find a better organization.
Also moves the existing alpha deployments to this new format for Polygon, Sepolia, and Base-Sepolia.