-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cross-arch): add cross arch release pipeline #487
Conversation
95639a0
to
42dd119
Compare
c3e1109
to
07f537e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Final couple requests here:
-
How much of this is tested? What is the testing plan? Do we need to merge first and then iterate?
-
Can you write 2 docs to support this code:
a. release.md explaining the release process
b. Update docker.md explaining the use of the 3 docker files, an overview of how to do builds, note anything that we had to do what wasn't intuitive, etc.
@dancoombs The annoying thing about github is you cannot test updated workflows unless they are first in the default branch. We will need to merge first and then I will manually run each of them. I have added an override for the git tag in the workflow dispatch for patches and inital testing deploying to dockerhub |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 59 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions, approving to unblock testing, we'll likely iterate on this a few times during testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #421
Proposed Changes