Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(err): use warn instead of debug #916

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(err): use warn instead of debug #916

merged 1 commit into from
Nov 25, 2024

Conversation

0xfourzerofour
Copy link
Collaborator

Proposed Changes

  • Update the chain tracking logic to use warn

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.13%. Comparing base (6817ed7) to head (ee1dad3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/pool/src/chain.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/chain.rs 93.65% <0.00%> (ø)
Flag Coverage Δ
unit-tests 59.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.06% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.64% <0.00%> (ø)
provider 20.84% <ø> (ø)
rpc 25.87% <ø> (ø)
sim 76.76% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.81% <ø> (ø)
utils 31.73% <ø> (ø)
---- 🚨 Try these New Features:

@0xfourzerofour 0xfourzerofour merged commit db86d73 into main Nov 25, 2024
10 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/warn-log branch November 25, 2024 17:34
@0xfourzerofour 0xfourzerofour restored the josh/warn-log branch November 25, 2024 17:34
@0xfourzerofour 0xfourzerofour mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysim3d andysim3d andysim3d approved these changes

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xfourzerofour @andysim3d