Various fixes #293
Merged
Various fixes #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from a state space representation according to the method on pg. 140
alchemyst
approved these changes
Jun 5, 2017
| root_builder[i][1] += 1 | ||
| repeated = True | ||
| break | ||
| if not repeated: |
There was a problem hiding this comment.
This pattern of using a flag is why Python's for has an else. http://book.pythontips.com/en/latest/for_-_else.html#else-clause
| root_builder = [] | ||
| for root in roots: | ||
| repeated = False | ||
| for i in range(len(root_builder)): |
There was a problem hiding this comment.
for x in range is a bit of an antipattern in Python. Especially this form range(len(. Check out https://nedbatchelder.com/text/iter.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed poles, zeros and bug in mimotf_slice. This should resolve issues #178 and #179. Modified sv_dir_plot in utilsplot.py to plot magnitude and phase of direction vectors. Previously it just plotted the real values and discarded the imaginary parts.