Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Commit

Permalink
distribute operations integration tests (#3706)
Browse files Browse the repository at this point in the history
Moves operations integration backup tests into a
subpackage, and slices up the test folder into
multiple, service specific folders.

No logic changes, only code copy-pasting and
renaming.

---

#### Does this PR need a docs update or release note?

- [x] ⛔ No

#### Type of change

- [x] 🤖 Supportability/Tests

#### Test Plan

- [x] 💚 E2E
  • Loading branch information
ryanfkeepers authored Jul 5, 2023
1 parent 8cc3069 commit fe6ae28
Show file tree
Hide file tree
Showing 11 changed files with 2,509 additions and 2,096 deletions.
8 changes: 4 additions & 4 deletions src/internal/operations/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ type BackupOperation struct {
Selectors selectors.Selector `json:"selectors"`
Version string `json:"version"`

// backupVersion ONLY controls the value that gets persisted to the
// BackupVersion ONLY controls the value that gets persisted to the
// backup model after operation. It does NOT modify the operation behavior
// to match the version. Its inclusion here is, unfortunately, purely to
// facilitate integration testing that requires a certain backup version, and
// should be removed when we have a more controlled workaround.
backupVersion int
BackupVersion int

account account.Account
bp inject.BackupProducer
Expand Down Expand Up @@ -83,7 +83,7 @@ func NewBackupOperation(
ResourceOwner: owner,
Selectors: selector,
Version: "v0",
backupVersion: version.Backup,
BackupVersion: version.Backup,
account: acct,
incremental: useIncrementalBackup(selector, opts),
bp: bp,
Expand Down Expand Up @@ -258,7 +258,7 @@ func (op *BackupOperation) Run(ctx context.Context) (err error) {
sstore,
opStats.k.SnapshotID,
op.Results.BackupID,
op.backupVersion,
op.BackupVersion,
deets.Details())
if err != nil {
op.Errors.Fail(clues.Wrap(err, "persisting backup"))
Expand Down
Loading

0 comments on commit fe6ae28

Please sign in to comment.