Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings about missing EEx #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RobertDober
Copy link

This should us rid of

==> benchfella
Compiling 9 files (.ex)
warning: EEx.compile_file/2 defined in application :eex is used by the current application but the current application does not depend on :eex. To fix this, you must do one of:

  1. If :eex is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :eex is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :eex, you may optionally skip this warning by adding [xref: [exclude: [EEx]]] to your "def project" in mix.exs

  lib/mix/tasks/bench_graph.ex:93: Mix.Tasks.Bench.Graph

mix.exs Outdated
@@ -1,4 +1,4 @@
defmodule Benchfella.Mixfile do
defmodule Benchfella.Mixfile do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would humbly advice to run mix format mix.exs, commit and git rebase -i, then force-push into your PR branch to fix this excessive indentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG how did that happen :(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix coming up

@@ -16,7 +16,10 @@ defmodule Benchfella.Mixfile do
end

def application do
[applications: []]
[
applications: [],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure that with newer Elixirs applications: is obligatory even.
Consider [a patch that fixes similar issue in inch_ex.

I would just leave extra_applications: [:eex]. I think it would be wise to also verify why does this supress the warning.

My hypothesis is that it has to do with the fact that newer Elixirs now know how to assemble minimal releases, but need a little help with figuring out which bits and bobs from the full Elixir distribution to include, but I'm not 💯% sure...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know I very simply did what the warning said 🤷

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but looking at the link you provided I would say they just did the same, no?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite. Note how inch_ex dropped applications key entirely.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do that too of course I will not complain, is there any action on my side yet?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobertDober I don't think so, now we wait for the maintaners, hah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants