Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Medals.cs #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Medals.cs #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions BugFablesLib/Sources/Names/Medals.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public static partial class BfVanillaNames
"Miracle Matter",
"Victory Buzz",
"Triumph Buzz",
"Ambusher",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the game: this enum needs to match the one that's in game so the Ids matches, but all the new 1.2.0 medals were added at the end of the enum and in a specific order.

I also find it inefficient to add only a single one when you could add all of them, but you HAVE to follow the internal ids which are listed here: https://aldelaro5.github.io/Bug-Fables-Internal-Docs/Enums%20and%20IDs/Medal/#medals-table

Currently, you made this entry the new "crazy prepared" and made every other ids below off by one.

"Crazy Prepared",
"Life Cast",
"Hard Charge",
Expand Down