Better use of virtual destructor

aldelaro5 · Jun 30, 2018 · 2eea3bb · 2eea3bb
1 parent bf9c867
commit 2eea3bb
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 0 deletions.
diff --git a/Source/GUI/SeedFinder/SeedFinderPassPage.cpp b/Source/GUI/SeedFinder/SeedFinderPassPage.cpp
@@ -53,6 +53,10 @@ SeedFinderPassPage::SeedFinderPassPage(QWidget* parent, const int nbrFoundSeeds,
  setLayout(layout);
 }
 
+SeedFinderPassPage::~SeedFinderPassPage()
+{
+}
+
 void SeedFinderPassPage::setSeedFinderDone(const bool seedFinderDone)
 {
  m_seedFinderDone = seedFinderDone;

diff --git a/Source/GUI/SeedFinder/SeedFinderPassPage.h b/Source/GUI/SeedFinder/SeedFinderPassPage.h
@@ -13,6 +13,7 @@ class SeedFinderPassPage : public QWizardPage
 public:
  SeedFinderPassPage(QWidget* parent, const int nbrFoundSeeds, const int rtcErrorMarginSeconds,
  const bool useWii, const bool usePrecalc);
+ ~SeedFinderPassPage();
 
  int nextId() const override;
 

diff --git a/Source/GUI/Settings/ColosseumTab.cpp b/Source/GUI/Settings/ColosseumTab.cpp
@@ -18,6 +18,12 @@ ColosseumTab::ColosseumTab(QWidget* parent) : QWidget(parent)
  setLayout(mainLayout);
 }
 
+ColosseumTab::~ColosseumTab()
+{
+ delete m_predictorFiltersUmbreon;
+ delete m_predictorFiltersEspeon;
+}
+
 CommonPredictorFiltersWidget* ColosseumTab::getUmbreonFiltersWidget() const
 {
  return m_predictorFiltersUmbreon;

diff --git a/Source/GUI/Settings/ColosseumTab.h b/Source/GUI/Settings/ColosseumTab.h
@@ -9,6 +9,7 @@ class ColosseumTab : public QWidget
 {
 public:
  ColosseumTab(QWidget* parent = nullptr);
+ ~ColosseumTab();
 
  CommonPredictorFiltersWidget* getUmbreonFiltersWidget() const;
  CommonPredictorFiltersWidget* getEspeonFiltersWidget() const;

diff --git a/Source/GUI/Settings/CommonPredictorFiltersWidget.cpp b/Source/GUI/Settings/CommonPredictorFiltersWidget.cpp
@@ -131,6 +131,10 @@ CommonPredictorFiltersWidget::CommonPredictorFiltersWidget(QWidget* parent) : QW
  setLayout(mainLayout);
 }
 
+CommonPredictorFiltersWidget::~CommonPredictorFiltersWidget()
+{
+}
+
 int CommonPredictorFiltersWidget::getMinHpIv() const
 {
  return m_spnMinHpIv->value();

diff --git a/Source/GUI/Settings/CommonPredictorFiltersWidget.h b/Source/GUI/Settings/CommonPredictorFiltersWidget.h
@@ -11,6 +11,7 @@ class CommonPredictorFiltersWidget : public QWidget
 {
 public:
  CommonPredictorFiltersWidget(QWidget* parent = nullptr);
+ virtual ~CommonPredictorFiltersWidget();
 
  int getMinHpIv() const;
  int getMinAtkIv() const;

diff --git a/Source/GUI/Settings/GaleDarknessTab.cpp b/Source/GUI/Settings/GaleDarknessTab.cpp
@@ -36,6 +36,11 @@ GaleDarknessTab::GaleDarknessTab(QWidget* parent) : QWidget(parent)
  setLayout(mainLayout);
 }
 
+GaleDarknessTab::~GaleDarknessTab()
+{
+ delete m_predictorFiltersEevee;
+}
+
 CommonPredictorFiltersWidget* GaleDarknessTab::getEeveeFiltersWidget() const
 {
  return m_predictorFiltersEevee;

diff --git a/Source/GUI/Settings/GaleDarknessTab.h b/Source/GUI/Settings/GaleDarknessTab.h
@@ -10,6 +10,7 @@ class GaleDarknessTab : public QWidget
 {
 public:
  GaleDarknessTab(QWidget* parent = nullptr);
+ ~GaleDarknessTab();
 
  CommonPredictorFiltersWidget* getEeveeFiltersWidget() const;
  GUICommon::shininess getShininess() const;