Support hex/oct/binary representation of floating-point entries #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristian64
reviewed
Apr 25, 2024
|
I've updated the PR to address @cristian64's suggestion above. Testing looks good on my end for float/double reading/writing. |
|
@malleoz In case you've missed it, it seems the formatting is not compliant with the rules defined in the |
cristian64
reviewed
Apr 26, 2024
|
@malleoz It seems an unrelated commit has been added to the branch inadvertently. Also, I think the one commit and PR title could be reworded to mention octal and binary representation too (not only hex anymore). |
malleoz
changed the title
|
Done and done. Sorry I had cherry-picked another commit to make my own executable for personal use, and forgot to remove when making changes! |
cristian64
approved these changes
Apr 26, 2024
dreamsyntax
approved these changes
Apr 26, 2024
|
Tested on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #115