Warn user about other instances owning the settings file. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamsyntax
approved these changes
May 12, 2024
When multiple DME instances are created, only the first one gets to own the settings file now; previously, the last DME instance to close would rewrite the settings file, potentially causing data loss from the previous instances. A warning dialog will be shown on startup if the settings lockfile cannot be acquired. On exit, if there are unsaved changes to the watch list, the user will be given an opportunity to save it into a separate `.dmw` file.
cristian64
force-pushed
the
ephemeral_settings_warning
branch
from
9f75a21
to
d8eb1eb
Compare
dreamsyntax
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple DME instances are created, only the first one gets to own the settings file now; previously, the last DME instance to close would rewrite the settings file, potentially causing data loss from the previous instances.
A warning dialog will be shown on startup if the settings lockfile cannot be acquired. On exit, if there are unsaved changes to the watch list, the user will be given an opportunity to save it into a separate
.dmwfile.