Avoid memory leaks in MemWatchModel::clearRoot().
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veChildren()`. This method did not (and still does not) delete the memory of the removed children; it merely removes the children from the parent's child list. This behavior matches the `removeChild(int)` method, which does not free the memory of the removed child either.
Unlike `removeChildren()` (previously `clearAllChild()`), this method does free the memory of the removed children.
The method would previously remove children, but without deleting them.
dreamsyntax
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemWatchModel::clearAllChild()has been renamed toMemWatchModel::removeChildren().MemWatchModel::deleteChildren()has been added. UnlikeremoveChildren(), this new method does free the memory of the removed children.MemWatchModel::clearRoot(), which would previously only remove children but without deleting them.