Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat failed save actions as cancel actions. #146

Merged

Commits on May 18, 2024

  1. Treat failed save actions as cancel actions.

    Previously, if the user exited the file browser dialog without saving
    the file (voluntarily, or due to I/O error), DME would still exit (or
    wipe out the watch model; depending on the case), causing unrecoverable
    data loss.
    
    Test plan:
    - Launch DME.
    - Add a few watch entries to mark the model with unsaved changes.
    - Clear the watch list via the **File > Clear the watch list** action.
    - A confirmation dialog with the **Cancel**, **No**, and **Yes** options
      should appear.
    - Click **Yes**
    - Once the file browser dialog opens, close it without selecting a file
      (or choose a filepath where the user does not have write permissions).
    
    Previous behavior: The watch list was wrongly cleared, without the user
    having saved it.
    
    New behavior: The user gets back to DME, as if **Cancel** had been
    selected in the confirmation dialog.
    cristian64 committed May 18, 2024
    Configuration menu
    Copy the full SHA
    6fc6691 View commit details
    Browse the repository at this point in the history