Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user before destructive operations of great impact. #147

Merged
merged 4 commits into from
May 19, 2024

Conversation

cristian64
Copy link
Collaborator

@cristian64 cristian64 commented May 18, 2024

The Clear the watch list action did not always show a confirmation dialog, only when there were unsaved changes, which overlooked the case where the watch list is only backed up by the data stored in the settings file.

@dreamsyntax
Copy link
Collaborator

I dislike having a prompt for Cut.

If we want this it should be a configurable Option state that can be enabled/disabled

"Confirm Cut" or "Confirm on Cut" etc as the name

@aldelaro5
Copy link
Owner

Yeah I am not a big fan of confirm on cut either.

For clear list, it's reasonable (maybe it can offer a save before, but I am fine either way). It's just cut is one that you may do very frequently enough.

@cristian64
Copy link
Collaborator Author

Yeah I am not a big fan of confirm on cut either.

For clear list, it's reasonable (maybe it can offer a save before, but I am fine either way). It's just cut is one that you may do very frequently enough.

I guess the data is still in the clipboard, so no need to bother the user when cutting.

@dreamsyntax
Copy link
Collaborator

Yeah I am not a big fan of confirm on cut either.

For clear list, it's reasonable (maybe it can offer a save before, but I am fine either way). It's just cut is one that you may do very frequently enough.

I guess the data is still in the clipboard, so no need to bother the user when cutting.

Just an additional data point most modern OS/DE ship clipboard history by default now too, so id be fine not having that feature at all.

This matches the behavior of the delete action, which always prompts the
the user.
"Remove" generally implies that the data has not been deleted, only
moved to another place, which is not the case with this function.
@cristian64
Copy link
Collaborator Author

I've now dropped the changes for the cut action.

@dreamsyntax dreamsyntax merged commit 31d2a0e into aldelaro5:master May 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants