Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Light, Dark Gray, and Dark themes along with the System theme. #149

Merged
merged 1 commit into from
May 24, 2024

Conversation

cristian64
Copy link
Collaborator

@cristian64 cristian64 commented May 18, 2024

The following themes are offered:

  • System: Purely based on Qt's Fusion built-in style
  • Light: Qt's Fusion built-in style + custom light palette
  • Dark Gray: Qt's Fusion built-in style + custom dark gray palette
  • Dark: Qt's Fusion built-in style + custom dark palette
Light Dark Gray Dark
DME - Light Theme DME - Dark Gray Theme DME - Dark Theme

@dreamsyntax
Copy link
Collaborator

Lint failed.

Im fine with this if we extend to be part of the theme switcher which is currently Windows only.

Since default linux/mac already has dark mode iff using appropriate Qt theme selection on your system.

@dreamsyntax
Copy link
Collaborator

Light:
image

Dark:
image

--

I think for Linux/Mac platforms we should probably specify that 'Light' is actually your default Qt theme- so in my case of using EndeavourOS Cinnamon with Dark Mode Qt / Dark themes looks as above for each option.

@cristian64
Copy link
Collaborator Author

[...]

I think for Linux/Mac platforms we should probably specify that 'Light' is actually your default Qt theme- so in my case of using EndeavourOS Cinnamon with Dark Mode Qt / Dark themes looks as above for each option.

This is the part I mentioned I'd like to discuss. Right now, the naked use of the Fusion built-in style means "use the system's". Isn't that the case on Windows too? I would have thought a user having the light theme on Windows would still see a light theme in DME when the current Dark mode is selected.

We could offer the following options for the Theme setting:

  • Default (or System): the Fusion built-in style as-is
  • Dark: Fusion + custom dark palette
  • Light: Fusion + custom light palette

This would guarantee that the Dark and Light styles look alike in all platforms.

@dreamsyntax
Copy link
Collaborator

Right now, the naked use of the Fusion built-in style means "use the system's". Isn't that the case on Windows too? I would have thought a user having the light theme on Windows would still see a light theme in DME when the current Dark mode is selected.

You are correct, just tested this. It does follow system theme.

@cristian64 cristian64 changed the title Add support for dark theme on Linux and macOS. Add Light and Dark themes along with the System theme. May 19, 2024
@dreamsyntax
Copy link
Collaborator

dreamsyntax commented May 23, 2024

Minor nitpick, can we make the names expose the theme names? Like how DuckStation/PCSX2 do it?

The system dark on Windows for example is Fusion Dark,
Where the "Dark" option is actually Dark Fusion (Gray)

image

image

DuckStation/PCSX2 example:
image

@cristian64 cristian64 changed the title Add Light and Dark themes along with the System theme. Add Light, Dark Gray, and Dark themes along with the System theme. May 23, 2024
The following themes are offered:

- **System**: Purely based on Qt's Fusion built-in style
- **Light**: Qt's Fusion built-in style + custom light palette
- **Dark Gray**: Qt's Fusion built-in style + custom dark gray palette
- **Dark**: Qt's Fusion built-in style + custom dark palette

| Light | Dark Gray | Dark |
| --- | --- | --- |
| ![DME - Light Theme](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/4bf0d1af-36fb-4698-b70a-988b5f003bf4) | ![DME - Dark Gray Theme](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/12d77606-668b-40aa-b146-cc08616553dc) | ![DME - Dark Theme](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/59493fbd-fcfb-4e55-a99e-5efba71f62be) |
Copy link
Collaborator

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note this will drop WindowsVistaTheme, but I think it doesn't look that different compared to Fusion Light anyway.

Tested on Linux and on Windows

@dreamsyntax dreamsyntax merged commit 0f988e3 into aldelaro5:master May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants