Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test typescript code coverage using jest #7

Closed
wants to merge 1 commit into from

Conversation

aldousalvarez
Copy link
Owner

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@aldousalvarez aldousalvarez marked this pull request as draft March 13, 2024 06:00
@aldousalvarez aldousalvarez force-pushed the code-coverage branch 4 times, most recently from e9c137c to 0322b51 Compare March 13, 2024 09:13
Copy link
Collaborator

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldousalvarez Not bad. You can build on this towards the end solution. Things to keep in mind:

  1. separate jobs will have to share their code coverage outputs somehow via the GitHub action cache or via the artifact store (whichever is a better fit - to be investigated)
  2. We can't re-run the entire test suite just to obtain coverage data so this has to be done in a way that is integrated with the current test execution as-is.

@aldousalvarez aldousalvarez force-pushed the code-coverage branch 11 times, most recently from 122c2ce to c4413b9 Compare April 22, 2024 08:30
@aldousalvarez aldousalvarez force-pushed the main branch 5 times, most recently from 4dc803d to 0b0c22c Compare July 2, 2024 07:14
@aldousalvarez aldousalvarez force-pushed the main branch 3 times, most recently from 97d0cc9 to 6bfd3e0 Compare December 5, 2024 02:34
@aldousalvarez aldousalvarez force-pushed the main branch 5 times, most recently from 5c7dbba to c66a1c6 Compare December 6, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants