Optimize to_binary() function and to_bytes() method #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems, that using mpn_get_str() is more efficient than generic mpz_export().
Some benchmarks are here:
#404 (comment)
Not sure what else we can do for #404. In the python-gmp I've added also the
__reduce__
dunded method. This seems slightly better than rely on copyreg to support pickling:Can we add pickling to the gmpy2 with even less overhead? I don't know.
But if we avoid pickle machinery, you can see noticeable performance boost for small numbers too:
New code seems faster than int.to_bytes() roughly from 500bit numbers on my system.
benchmark code