Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change session cleanup mechanism #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yegorius
Copy link

@yegorius yegorius commented Apr 16, 2024

I don't feel comfortable when there is a whole bash process hanging out there and waiting for the sway to exit. I think there is a better approach to this. Similar to good old pid files, we can store env variables in the user's runtime dir and use it to clean up the session.
The only significant change is that now we must exit sway by calling session.sh --exit.
Currently the config command looks like this: exec /usr/lib/sway-systemd/session.sh --exit
In order to make it look better, I suggest moving session.sh to /usr/bin/ and renaming it to sway-session so that the final command looks like this: exec sway-session --exit
WDYT?

@yegorius
Copy link
Author

yegorius commented Oct 8, 2024

Any feedback about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant