Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't feel comfortable when there is a whole bash process hanging out there and waiting for the sway to exit. I think there is a better approach to this. Similar to good old pid files, we can store env variables in the user's runtime dir and use it to clean up the session.
The only significant change is that now we must exit sway by calling
session.sh --exit
.Currently the config command looks like this:
exec /usr/lib/sway-systemd/session.sh --exit
In order to make it look better, I suggest moving
session.sh
to/usr/bin/
and renaming it tosway-session
so that the final command looks like this:exec sway-session --exit
WDYT?