New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getBlockIndexes method, rename orphan to stale #115

Merged

alecalve merged 1 commit into master from blockchain-refactor

Mar 23, 2024

Owner

alecalve commented Mar 23, 2024

Orphan blocks are blocks whose parents are unknown.
Stale blocks are blocks which lack confirmations.


          Remove getBlockIndexes method, rename orphan to stale

2d89d26

pep8speaks commented Mar 23, 2024

Hello @alecalve! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file blockchain_parser/blockchain.py:

Line 154:17: E265 block comment should start with '# '
Line 156:80: E501 line too long (93 > 79 characters)
Line 170:80: E501 line too long (88 > 79 characters)
Line 196:80: E501 line too long (95 > 79 characters)

alecalve merged commit cd20851 into master

3 checks passed

alecalve deleted the blockchain-refactor branch

March 23, 2024 16:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet