Switch to using pointers everywhere with arbitrary_self_types #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add endpoint parameter for automating releases
spaces rather than hyphens in wip label
Remove mistaken condition from mergify config
…d invalid references
alecmocatta
changed the title
alecmocatta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
uninitialized_boxas well as uninitialized fat references, replacing them with fat pointers thanks to thearbitrary_self_typesfeature.Two instances of uninitialized references remains. One is blocked on rust-lang/rfcs#2017. It could be removed if we're okay with
<dyn Trait as Type>::dangling()returning pointers with a fixed alignment (say 64 or 4096?). The other is blocked on getting slice length from a pointer; this could be removed if we're okay with assuming the layout and getting it ourselves.