fix: concurrent styles map access #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sync.Map to avoid concurrent map access "concurrent map writes" fatal error.
|
Thanks for the PR, but I don't think this is the right approach:
My suggestion would be to either maintain your own registry (it's just a convenience map), or pull the locking up to a higher level. |
|
That said, the LexerRegistry is a different case and making it concurrent safe does make sense as it's part of the lexer API and can't be worked around. |
aymanbagabas
added a commit
to charmbracelet/soft-serve
that referenced
this pull request
Jul 27, 2022
aymanbagabas
added a commit
to charmbracelet/soft-serve
that referenced
this pull request
Jul 28, 2022
aymanbagabas
added a commit
to charmbracelet/soft-serve
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sync.Map to avoid concurrent map access "concurrent map writes"
fatal error.