Extend DurationVar() to support days, weeks #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the open source package str2duration (which is a wrapper) around time.ParseDuration, to parse duration args from strings. This package supports more time formats, including days and weeks.
|
Thank you @alecthomas for the super quick response. Kingpin's been great to us and I appreciate you popping in to support |
jkowalski
added a commit
to jkowalski/kopia
that referenced
this pull request
Jul 10, 2022
This was caused by a default `-1ns` which is no longer supported in latest Kingpin. The effect was that `kopia cache set` without `--max-list-cache-duration` would fail. Unforutnately test was passing that flag so it was missed. This was likely caused by alecthomas/kingpin#329
jkowalski
added a commit
to kopia/kopia
that referenced
this pull request
Jul 10, 2022
This was caused by a default `-1ns` which is no longer supported in latest Kingpin. The effect was that `kopia cache set` without `--max-list-cache-duration` would fail. Unforutnately test was passing that flag so it was missed. This was likely caused by alecthomas/kingpin#329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the open source package str2duration (which is a wrapper)
around time.ParseDuration, to parse duration args from strings.
This package supports more time formats, including days and weeks.
This closes #328