Release 1.1.2 #17
Merged
Release 1.1.2 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPstan is used on every PHP files of the extension. The composer file had to be updated to include freshrss as dependency of the project to be able to validate type-hints.
The PSR12 coding standard has been enforce by using php-cs-fixer.
All commands used in the pipeline have been added to a Makefile in order to reproduce the same behavior locally without fiddling with parameters.
This is needed since Reddit API imposed a request rate limit recently. Without this delay between queries, feeds are marked as failing and pictures and videos might not be retrieved. Adding a 1-second (default) delay fixes 90% of the errors. Adding a 2-second delay fixes 100% of the errors with a lot of feeds (about 125 reddit feeds). If you have more feeds, you might consider a longer delay.
Gfycat was discontinued on September, 1st 2023. There is no need to keep that code alive. See https://en.wikipedia.org/wiki/Gfycat
Redgifs requires some kind of token to display images so we can not rely on the URL to access the image. The token is short lived so it needs to be handled differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.