-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] fit_compute_func API #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid confusion with None being used to _ignore_ fit_compute.
Also make Node.[step|inputs|outputs|targets] read-only.
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
+ Coverage 97.87% 97.9% +0.03%
=========================================
Files 13 13
Lines 705 764 +59
Branches 130 142 +12
=========================================
+ Hits 690 748 +58
Misses 11 11
- Partials 4 5 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fit_compute_func
toStep.__call__
that allows to specify custom behavior at fit time."auto"
to specify automatic detection ofcompute_func
andfit_compute_func
, reserveNone
to disable thefit_compute_func
.make_step
via aattr_dict
argument. This is useful to add customfit_predict
/fit_transform
methods.The motivation follows the rationale in Issue #16:
sklearn.manifold.TSNE
,sklearn.cluster.AgglomerativeClustering
).fit_transform
more efficient than callingfit
andtransform
separately.